Skip to content

src: remove unused private field #60802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: remove unused private field #60802

wants to merge 1 commit into from
+0 −1

Conversation

@targos
Copy link
Member

@targos targos commented Nov 21, 2025

Refs: #59828

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 21, 2025
@targos targos mentioned this pull request Nov 21, 2025
Closed
@targos
Copy link
Member Author

targos commented Nov 21, 2025

If there's a good reason to keep it, we should instead put a comment and disable compiler warnings.

@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (d729bec) to head (35cece7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60802      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         703      703              
  Lines      208259   208259              
  Branches    40162    40158       -4     
==========================================
- Hits       184415   184400      -15     
- Misses      15844    15887      +43     
+ Partials     8000     7972      -28
Files with missing lines Coverage Δ
src/node.h 95.91% <ø> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas
legendecas reviewed Nov 22, 2025
View reviewed changes
src/node.h
CallbackScope(CallbackScope&&) = delete;

private:
void* resource_storage_global_;
Copy link
Member

@legendecas legendecas Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure is a public API and changing the private fields will change the size of the struct and cause ABI incompatibility.

This field was named as reserved_.

This should be a semver-major change.

Copy link
Member Author

@targos targos Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to keep it if it's reserved for something. Do you have a suggestion for an explaining comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@targos @legendecas @nodejs-github-bot